-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump compliment to 0.3.7-SNAPSHOT #553
Conversation
I see some completion tests failing. Maybe it's something random, but it'd be nice if you can take a look at them. |
I'd wait for master to green up first :). |
@alexander-yakushev There are always some debugger related flaky tests, but usually most builds in the matrix are green. In this case I'm mostly worried that here https://travis-ci.org/clojure-emacs/cider-nrepl/jobs/442107912 there are some completion related tests. Just take a look at them. Perhaps that's also some flakiness give that most builds have passed, but it just seems like a weird thing. |
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=========================================
Coverage ? 73.03%
=========================================
Files ? 36
Lines ? 2388
Branches ? 139
=========================================
Hits ? 1744
Misses ? 505
Partials ? 139 Continue to review full report at Codecov.
|
OK, tests are really failing with JDK9 and 0.3.7, and they fail completely. This is weird. I only have 10 locally, so trying to run tests against 10 on Travis. |
I guess now only 8 and 11 are important. 9 and 10 reached their EOL
already.
On Tue, 16 Oct 2018 at 19:00, Alexander Yakushev ***@***.***> wrote:
OK, tests are really failing with JDK9 and 0.3.7, and they fail
completely. This is weird. I only have 10 locally, so trying to run tests
against 10 on Travis.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#553 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGVyuXbUc0v1BN2CJCg3JdkT8C8xrh3ks5ulhCZgaJpZM4XeE36>
.
--
Best Regards,
Bozhidar Batsov
http://www.batsov.com
|
ffce221
to
962f72e
Compare
OK, I give up. JDK10 fails with something completely off, and with JDK11 the completion works but something from cljs fails. Can I defer this until you bump the tests to JDK11 and resolve the other issues with it? |
962f72e
to
41660ce
Compare
This version of Compliment fixes the class name completion on JDK9+.