Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compliment to 0.3.7-SNAPSHOT #553

Merged
merged 2 commits into from
Oct 26, 2018
Merged

Conversation

alexander-yakushev
Copy link
Member

This version of Compliment fixes the class name completion on JDK9+.

@bbatsov
Copy link
Member

bbatsov commented Oct 16, 2018

I see some completion tests failing. Maybe it's something random, but it'd be nice if you can take a look at them.

@alexander-yakushev
Copy link
Member Author

alexander-yakushev commented Oct 16, 2018

I'd wait for master to green up first :). lein with-profile +1.9,+test-clj works locally on JDK8 and 10 though.

@bbatsov
Copy link
Member

bbatsov commented Oct 16, 2018

@alexander-yakushev There are always some debugger related flaky tests, but usually most builds in the matrix are green. In this case I'm mostly worried that here https://travis-ci.org/clojure-emacs/cider-nrepl/jobs/442107912 there are some completion related tests. Just take a look at them. Perhaps that's also some flakiness give that most builds have passed, but it just seems like a weird thing.

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@09db6a7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #553   +/-   ##
=========================================
  Coverage          ?   73.03%           
=========================================
  Files             ?       36           
  Lines             ?     2388           
  Branches          ?      139           
=========================================
  Hits              ?     1744           
  Misses            ?      505           
  Partials          ?      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09db6a7...41660ce. Read the comment docs.

@alexander-yakushev
Copy link
Member Author

OK, tests are really failing with JDK9 and 0.3.7, and they fail completely. This is weird. I only have 10 locally, so trying to run tests against 10 on Travis.

@bbatsov
Copy link
Member

bbatsov commented Oct 16, 2018 via email

@alexander-yakushev alexander-yakushev force-pushed the alexander-yakushev-patch-1 branch 2 times, most recently from ffce221 to 962f72e Compare October 16, 2018 19:05
@alexander-yakushev
Copy link
Member Author

OK, I give up. JDK10 fails with something completely off, and with JDK11 the completion works but something from cljs fails.

Can I defer this until you bump the tests to JDK11 and resolve the other issues with it?

@bbatsov bbatsov merged commit b3ee629 into master Oct 26, 2018
@bbatsov bbatsov deleted the alexander-yakushev-patch-1 branch October 26, 2018 17:04
bbatsov pushed a commit that referenced this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants