Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cider-jack-in on tramp buffers #489

Merged
merged 1 commit into from
Mar 16, 2014

Conversation

hugoduncan
Copy link
Member

When using cider-jack-in in a tramp source buffer, starts a remote nrepl
server, and connects to it. By default, sets up an ssh tunnel to the
remote port. This can be controlled using
nrepl-on-connection-function, which defaults to
nrepl-connection-ssh-tunnel.

@bbatsov
Copy link
Member

bbatsov commented Mar 1, 2014

That's a very neat feature! I'll have to take a closer look at the code, but after taking a quick glance I noticed that you don't check for the presence of ssh at all. I guess most people have the client installed (at least on Unices), but an executable-find check won't hurt.


(defun nrepl--run-on-connection (dir port)
"Run any nrepl-on-connection-function for DIR and PORT.
Return a plist with :hostname and :port values, specifying
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the leading whitespace.

@bbatsov
Copy link
Member

bbatsov commented Mar 2, 2014

P.S. You'll also have to rebase on top of the current master.

@bbatsov
Copy link
Member

bbatsov commented Mar 8, 2014

@hugoduncan Ping

When using cider-jack-in in a tramp source buffer, starts a remote nrepl
server, and connects to it. By default, sets up an ssh tunnel to the
remote port. This can be controlled using nrepl-connection-endpoint,
which defaults to nrepl-connection-ssh-tunnel.
@hugoduncan
Copy link
Member Author

Renamed to nrepl-connection-endpoint, removed destructuring-bind. Rebased and squashed.

bbatsov added a commit that referenced this pull request Mar 16, 2014
Enable cider-jack-in on tramp buffers
@bbatsov bbatsov merged commit 40b6f1c into clojure-emacs:master Mar 16, 2014
@bbatsov
Copy link
Member

bbatsov commented Mar 16, 2014

Thanks!

bbatsov pushed a commit that referenced this pull request Mar 22, 2014
@bbatsov
Copy link
Member

bbatsov commented Mar 22, 2014

The update broke the ability to do cider-jack-in outside of a lein project. I did a quick fix in 8fb457d, but you might want to scan the code one more time for other potential problems, when used outside projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants