Enable cider-jack-in on tramp buffers #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a very neat feature! I'll have to take a closer look at the code, but after taking a quick glance I noticed that you don't check for the presence of |
|
|
||
| (defun nrepl--run-on-connection (dir port) | ||
| "Run any nrepl-on-connection-function for DIR and PORT. | ||
| Return a plist with :hostname and :port values, specifying |
|
P.S. You'll also have to rebase on top of the current master. |
|
@hugoduncan Ping |
When using cider-jack-in in a tramp source buffer, starts a remote nrepl server, and connects to it. By default, sets up an ssh tunnel to the remote port. This can be controlled using nrepl-connection-endpoint, which defaults to nrepl-connection-ssh-tunnel.
|
Renamed to |
bbatsov
added a commit
that referenced
this pull request
Mar 16, 2014
Enable cider-jack-in on tramp buffers
|
Thanks! |
bbatsov
pushed a commit
that referenced
this pull request
Mar 22, 2014
|
The update broke the ability to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using cider-jack-in in a tramp source buffer, starts a remote nrepl
server, and connects to it. By default, sets up an ssh tunnel to the
remote port. This can be controlled using
nrepl-on-connection-function, which defaults tonrepl-connection-ssh-tunnel.