Fix behavior of cider-switch-to-current-repl-buffer
#1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, another epic oversight on my part. Seems that I originally implemented this to affect only the REPL buffer creation... The fix looks good. Just add a changelog entry and we're good to go. |
whysoserious
pushed a commit
to whysoserious/cider
that referenced
this pull request
Jun 20, 2015
whysoserious
pushed a commit
to whysoserious/cider
that referenced
this pull request
Jun 20, 2015
|
Done. |
|
@whysoserious Please, squash the two commits together. No need to have them separately. |
whysoserious
force-pushed
the
fix-cider-switch-to-current-repl-buffer
branch
from
efc2299
to
fe6c136
Compare
|
Done. |
|
👍 Thanks! |
bbatsov
added a commit
that referenced
this pull request
Jun 20, 2015
…t-repl-buffer Fix behavior of `cider-switch-to-current-repl-buffer`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting in my config file
breaks behavior of
cider-repl-display-in-current-windowcommand. See it in action. Each change of window layout or buffer in the movie below is an effect of hittingC-c C-z:This PR hopefully fixes that (watch out - this is my first elisp PR ever).
Software versions:
; CIDER 0.9.1snapshot (package: 20150618.2308) (Java 1.8.0_25, Clojure 1.6.0, nREPL 0.2.8)GNU Emacs 24.4.1 (x86_64-apple-darwin13.4.0, NS apple-appkit-1265.21) of 2014-10-21 on builder10-9.porkrind.org