Refresh log + support for before and after refresh middleware opts
#1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cichli
force-pushed
the
refresh-before-after
branch
from
41f2f54
to
bede9da
Compare
|
The code looks great, but this definitely deserves some documentation in the README. We wouldn't want people to be totally unaware about such great functionality, right? |
| (defconst cider-refresh-log-buffer "*cider-refresh-log*") | ||
|
|
||
| (defcustom cider-refresh-before-fn nil | ||
| "Function for `cider-refresh' to call before reloading. |
There was a problem hiding this comment.
"Clojure function ..." I had to read this twice to understand it wasn't an emacs hook. :)
|
Forget my remark about the changelog. I'm way too tired today... |
cichli
force-pushed
the
refresh-before-after
branch
from
bede9da
to
fc8d114
Compare
Looks like |
cichli
force-pushed
the
refresh-before-after
branch
from
ed45df0
to
a2c404a
Compare
cichli
force-pushed
the
refresh-before-after
branch
from
a2c404a
to
09c65eb
Compare
bbatsov
added a commit
that referenced
this pull request
Jul 20, 2015
Refresh log + support for `before` and `after` refresh middleware opts
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on clojure-emacs/cider-nrepl#233. Current UI looks like this:
Feedback welcome!