Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for `(...) to the debugger #1235

Merged
merged 1 commit into from Aug 5, 2015
Merged

Add support for `(...) to the debugger #1235

merged 1 commit into from Aug 5, 2015

Conversation

Malabarba
Copy link
Member

This covers most cases, but it still doesn't cover when there's a hard quote inside the backticked form.

This covers most cases, but it still doesn't cover when there's a
hard quote inside the backticked form.
@@ -4,6 +4,7 @@

### New features

* [#1235](https://github.com/clojure-emacs/cider/pull/1235): Add support backticked forms to the debugger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backticked -> for backticked (aka "syntax-quoted")

The sentence is missing its ..

@Malabarba
Copy link
Member Author

All done. 👍

@@ -4,6 +4,7 @@

### New features

* [#1235](https://github.com/clojure-emacs/cider/pull/1235): Add support for syntax-quoted forms to the debugger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The . is still missing here. :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah!

@Malabarba
Copy link
Member Author

Pushed again

bbatsov added a commit that referenced this pull request Aug 5, 2015
Add support for `(...) to the debugger
@bbatsov bbatsov merged commit 070f547 into clojure-emacs:master Aug 5, 2015
@bbatsov
Copy link
Member

bbatsov commented Aug 5, 2015

👍 Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants