[Fix #2941] Use main args in :cider/nrepl alias for clojure cli

[dpsutton]

Addresses #2941.

Hopefully the string building is a bit more clear with the format string

    (format "%s-Sdeps '{:deps {%s} :aliases {:cider/nrepl {:main-opts [%s]}}}' -M:cider/nrepl"
            (if global-opts (format "%s " global-opts) "")
            deps-string
            main-opts)

[dpsutton]

weird. i'm not seeing any CI. tests pass for me and "Linter has no complaints"

[dpsutton]

should this go away? i don't think it serves any purpose now. not sure the best cleanup of it. all the interesting stuff (refactor, etc) go in other places and the cider-clojure-cli-global-options is where you pass -A:dev:test and the like.

[bbatsov]

Yeah, I think it should go away. In general I still like the idea to simplify the config for each tool instead of just copying the original config for Lein everywhere.

[bbatsov]

Btw, if we're using the global options just for aliases, maybe we should rename it to something like cider-clojure-cli-aliases or whatever. I guess this might make things easier for the end users.

[bbatsov]

weird. i'm not seeing any CI. tests pass for me and "Linter has no complaints"

Perhaps we need to change something in the config? No idea why the CI results are not shown in the PR. I haven't changed the project config in ages.

[dpsutton]

@bbatsov wasn't sure what version to put here.

[dpsutton]

I think all i need from you is what version to put in the make-obsolete-variable and then to squash and we're good to go.

[bbatsov]

The next release is going to be 1.1.

[bbatsov]

I think you should update the docstring as well. :-)

[dpsutton]

good catch. thanks

[bbatsov]

And you should remove the params a couple of lines later. Now that the params are a bit different it might be a good idea to just list the params for each build tools separate (e.g. in subsections named "Leiningen", "Boot", etc).

[dpsutton]

which params should be removed? Not sure i'm following.

[bbatsov]

cider-clojure-cli-parameters is mentioned in the next paragraph.

[dpsutton]

oh totally. I was thinking this was in the code file cider.el and was super confused. Gotcha

[bbatsov]

Thanks!

[Bost]

I had in my .dir-locals.el

((clojure-mode . ((cider-preferred-build-tool . clojure-cli)
                  (cider-clojure-cli-global-options . "-J-Djdk.attach.allowAttachSelf"))))

Changing it to cider-clojure-cli-aliases doesn't work. cider-clojure-cli-parameters doesn't work either.

[dpsutton]

@Bost did you update? if you do m-x describe-variable [enter] cider-clojure-cli-parameters is the variable present? If so, does it say its current value due to the dir-locals? If not, try m-: (hack-local-variables) to try to make it pick up the new values.

then when i jack in its using -M:test:cider/nrepl:

;; Startup: /usr/local/bin/clojure -Sdeps '{:deps {nrepl/nrepl {:mvn/version "0.8.3"} cider/cider-nrepl {:mvn/version "0.25.8"}} :aliases {:cider/nrepl {:main-opts ["-m" "nrepl.cmdline" "--middleware" "["cider.nrepl/cider-middleware"]"]}}}' -M:test:cider/nrepl

[dpsutton]

ah dang. i just read through your usecase there. I don't think my changes work for that. I forgot about jvm parameters like that. I'll need to work something out for your use case. I'm really sorry about that.

[dpsutton]

the easiest workaround for you right now is to jack in with a prefix C-u C-c M-j and throw that string into the jack in command at the beginning. I had forgotten about those types of parameters.

[dpsutton]

@Bost so sorry about that. These changes should fix it for you. #2974

[Bost]

Not a big deal. Thanks for fixing it quickly! :)