Soften the warning around cider-nrepl version mismatches #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially given we try to inflict as few breaking changes as possible (#2960), a version mismatch might simply mean that one is using a more recent cider-nrepl version (without one having bothered to customize the related `defcustom` to silence this). This commit proposes a softer wording for the warning, so that people feel less alarmed in face of these. Else one gives the quite untruthful impression that things are more fragile/coupled than they actually are.
|
I like the current message more, as it's both short, informative and neutral. Once we get to the point of a really stable API we might not show any warning for newer cider-nREPL at all, but I don't think that we're quite there yet. At the very least we have to get to a 1.0 release soon. It might be a good idea to add a way to suppress those messages for users who really know what they are doing. Still, my observation is that almost no one outside of the people hacking on CIDER changes those versions, so such a configuration option might be an overkill. Btw, we never use terms like cider.el in the messages - it's always CIDER everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially given we try to inflict as few breaking changes as possible (#2960), a version mismatch might simply mean that one is using a more recent cider-nrepl version (without one having bothered to customize the related
defcustomto silence this).This commit proposes a softer wording for the warning, so that people feel less alarmed in face of these.
Else one gives the quite untruthful impression that things are more fragile/coupled than they actually are.