Replace newline chars with newlines in test report #3281
Conversation
| ;; messages more readable | ||
| (goto-char (point-min)) | ||
| (while (search-forward "\\n" nil t) | ||
| (replace-match " |
There was a problem hiding this comment.
Hmm, is there something else you can use that's visually clearer? I'm guessing an \n doesn't work, right?
There was a problem hiding this comment.
I'm guessing an \n doesn't work, right?
Correct
|
I'm okay with the fix, but it also needs a changelog entry. A regression test that verifies that this conversation works would be appreciated as well. |
expez
force-pushed
the
newlines-in-error-reports
branch
from
fcdc6e1
to
87b735f
Compare
Pushed
Is there an existing file for these tests, where I can insert a few choice lines? |
|
Not sure - I don't see a |
|
You'll also need to rebase on top of |
|
@expez Can you at least rebase this on top of |
When the library / app under test returns long error messages on test failures it will often include newlines. These are today displayed as `\\n` and we get an error message on one very long line. This commit turns these newline characters into actual newlines, which makes the content of the `*cider-test-report*` buffer much more pleasant to read.
expez
force-pushed
the
newlines-in-error-reports
branch
from
87b735f
to
6dd8193
Compare
|
@bbatsov done. Sorry about the slow response, travel and Christmas holiday got in the way. Happy new year! |
|
Happy new year! |
When the library / app under test returns long error messages on test
failures it will often include newlines. These are today displayed as
\\nand we get an error message on one very long line.This commit turns these newline characters into actual newlines, which
makes the content of the
*cider-test-report*buffer much more pleasantto read.
Before:
After:
