Interactive evaluation: show a shorter overlay when rendering compilation errors #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion errors e.g., the `Syntax error compiling clojure.core/let at (foo/bar.clj:10:1)` prefix is now removed.
bbatsov
reviewed
Oct 1, 2023
| @@ -822,9 +822,15 @@ when `cider-auto-inspect-after-eval' is non-nil." | |||
| (and cider-show-error-buffer | |||
| (member phase cider-clojure-compilation-error-phases))) | |||
| ;; Display errors as temporary overlays | |||
| (let ((cider-result-use-clojure-font-lock nil)) | |||
| (let ((cider-result-use-clojure-font-lock nil) | |||
| (trimmed-err (thread-last err | |||
There was a problem hiding this comment.
Might be good to add a comment explaining what this removes exactly, as it wasn't clear to me without reading the issue description. Potentially this can also be a small function with a unit test.
There was a problem hiding this comment.
cider-clojure-compilation-regexp happens to have nice tests, however I'll add a docstring to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g., the
Syntax error compiling clojure.core/let at (foo/bar.clj:10:1)prefix is now removed.Samples:
Cheers - V