Use sshx instead of ssh in cider-select-endpoint #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this change is safe. Thanks. |
|
@federkasten Sounds good. Please, mention this in the changelog as well. |
Modified cider-select-endpoint function to use sshx instead of ssh. This change is useful for users using well-configured login shell and ssh-config.
federkasten
force-pushed
the
ssh-to-sshx
branch
from
733de2b
to
0f0f082
Compare
|
I have modified CHANGELOG.md. Thanks. |
bbatsov
added a commit
that referenced
this pull request
Jan 19, 2015
Use sshx instead of ssh in cider-select-endpoint
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified
cider-select-endpointfunction to usesshxinstead ofssh.sshxis similar tosshwell.sshxjust opens a connection withssh -t -t host -l user /bin/sh.This means
So this is useful for users where normal login shell is configured heavily such as it asks them a number of questions when logging in.
This is also useful for users using well-configured
.ssh/configandssh-agent.(And the official document says Windows users will get some benefit, though I couldn't check it.)
Probably, this change is related to #822.
cf. http://www.gnu.org/software/tramp/