Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for SLIME #115

Merged
merged 2 commits into from
Dec 28, 2012
Merged

Conversation

bbatsov
Copy link
Member

@bbatsov bbatsov commented Dec 27, 2012

This is a pretty big change - it removes all the SLIME support that was part of clojure-mode. Since you've announced the deprecation of swank-clojure a while ago I think it's time we let go of the past. The SLIME support can live on in a separate branch (should you decide to create one) or in a separate source file like clojure-mode-slime (or something).

Dropping the SLIME support cleans up the clojure-mode code base significantly and will provide more focus to the development of nrepl.el which is clearly the future.

@technomancy
Copy link
Contributor

Cool; feels good to delete code.

The next release of clojure-mode will be 2.0.0 since we've introduced a number of breaking changes, so maybe we could add a note that if you still want slime support you can stick with version 1.x.

The diff for this is strange though--you're adding a paredit-mode defvar to a section of code that doesn't exist in my fork. Do you have some extra code to pacify the byte-compiler that this pull request doesn't include?

@bbatsov
Copy link
Member Author

bbatsov commented Dec 28, 2012

The diff looks strange because of the extra brace on that particular line - the paredit-mode defvar wasn't on the last line before the deletions. I'll update the README accordingly.

@technomancy
Copy link
Contributor

Never mind about the diff--my local copy was outdated. Thanks.

technomancy added a commit that referenced this pull request Dec 28, 2012
@technomancy technomancy merged commit b3a3c6a into clojure-emacs:master Dec 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants