Introduce inf-clojure-completions-fn defcustom #122
Conversation
inf-clojure.el
Outdated
| "Return completions for the Clojure expression starting with EXPR. | ||
|
|
||
| Its only ability is to parse a list of candidate strings, every | ||
| other EXPR will be discarded and nil will be returned." |
There was a problem hiding this comment.
Isn't EXPR only the completion prefix? Probably you didn't mean to reference it here. On a related note - we might pick a better name for this param.
There was a problem hiding this comment.
Open to suggestions :)
inf-clojure.el
Outdated
| with the candidates completion. See \\[completion-table-dynamic] | ||
| for more details. | ||
|
|
||
| The default value is the `inf-clojure-list-completions' function, |
There was a problem hiding this comment.
As the the default function does more than parsing the results (it's also invokes the Clojure completion code) this should probably the adjusted.
inf-clojure.el
Outdated
| (when (not (string-blank-p expr)) | ||
| (thread-first | ||
| (format (inf-clojure-completion-form) (substring-no-properties expr)) | ||
| (inf-clojure--process-response (inf-clojure-proc) "(" ")") | ||
| (inf-clojure--read-or-nil) | ||
| (inf-clojure--list-or-nil)))) | ||
|
|
||
| (defcustom inf-clojure-completions 'inf-clojure-list-completions |
There was a problem hiding this comment.
Won't inf-clojure-completions-fn (or something like this) be a better name?
There was a problem hiding this comment.
I like this better yes
inf-clojure.el
Outdated
| @@ -1254,15 +1254,43 @@ See variable `inf-clojure-buffer'." | |||
| "Return DATA if and only if it is a list." | |||
| (when (listp data) data)) | |||
|
|
|||
| (defun inf-clojure-completions (expr) | |||
| "Return a list of completions for the Clojure expression starting with EXPR." | |||
| (defun inf-clojure-list-completions (expr) | |||
There was a problem hiding this comment.
I don't like this name, as this function also invokes the code which generates the list it eventually processes. Not sure we won't to decouple only the part that actually processes the results. The way I see it completion has 3 stages:
- decide what's the Clojure code that will do the completion (e.g. we can set this per project or have some abilities check - try if compliment is present, fallback to
core.completeif this fails. Probably the first option would be easier and a better initial approach to this. ) - invoke that code and get some result from it
- decide how to process the results
There was a problem hiding this comment.
Yes I think I will take the send response out of the default function. I did not notice that inf-clojure-process-response was there. In my mind only the string should be passed down to the custom parsing function, as you said above.
arichiardi
force-pushed
the
completions-defcustom
branch
from
20015a1
to
f3962e9
Compare
arichiardi
changed the title
Now the user can provide a custom parsing function for completion and therefore has complete (pun intended) freedom in what to use for it. Some could use compliment completion for instance or even use directly what cider provides. The defcustom defaults to inf-clojure-list-completions, which can only parse candidates coming as a Lisp list of strings.
arichiardi
force-pushed
the
completions-defcustom
branch
from
f3962e9
to
8d22393
Compare
Now the user can provide a custom parsing function for completion and therefore
has complete (pun intended) freedom in what to use for it. Some could use
compliment completion for instance or even use directly what cider provides.
The defcustom defaults to inf-clojure-list-completions, which can only parse
candidates coming as a Lisp list of strings.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
M-x checkdocwarningsThanks!