Set REPL type from startup form, prompt, or defcustom at startup #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also prevent these when `inf-clojure` is invoked with a prefix arg
dpsutton
force-pushed
the
auto-repl-type
branch
from
447f89f
to
fd23517
Compare
arichiardi
reviewed
Apr 25, 2020
| There's some project detection but that's becoming less and less useful as time goes on. Shadow, lein, deps.edn can all easily be mixed in the same project. And then lumo, planck, or bb scripts could live side by side. Rather than trying to guess the project type, I think i'd like to mimic geiser's style of handling multiple scheme backends. Perhaps ~m-x inf-clojure-run-planck~ and similar could help out. | ||
|
|
||
| Some considerations: | ||
| - is this path aware? IE, don't show an option to run planck, lumo, etc, if they aren't visible or installed? |
There was a problem hiding this comment.
Imho to keep it simple not to have path inspection is a good start.
|
|
||
| Some considerations: | ||
| - is this path aware? IE, don't show an option to run planck, lumo, etc, if they aren't visible or installed? | ||
| - should it have a rebuild function so that user registered implementations can show up in the ~m-x~ menu as well? |
There was a problem hiding this comment.
If we go for the classic defcustom as list approach and maybe a register function like lsp imho yes
| (with-current-buffer (process-buffer proc) | ||
| (setq-local inf-clojure-repl-type type-to-set)))) | ||
|
|
||
| (defun inf-clojure--set-repl-type (proc) |
There was a problem hiding this comment.
Farewell, it has served as well-ish 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set REPL type at startup from startup form. Defcustom to override or set if custom startup form is used and otherwise prompt user for repl type.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
M-x checkdocwarningsThanks!