Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eval and def features to inspector #38

Merged
merged 4 commits into from Jan 4, 2019
Merged

Conversation

alexander-yakushev
Copy link
Member

Inspired by REBL, these are two features that would subsequently be available in CIDER inspector:

  • def the currently inspected value as a var.
  • prompt the user for an expression and eval it in the context where v is bound to the currently inspected value. Inspect the result just to be consistent.

@bbatsov
Copy link
Member

bbatsov commented Jan 2, 2019

That's pretty cool!

Don't forget to mention the changes in the changelog.

@bbatsov
Copy link
Member

bbatsov commented Jan 3, 2019

Btw, can you also take a look a this failure on JDK 11? Seems some class got removed/renamed.

@alexander-yakushev
Copy link
Member Author

This looks like a separate problem. Do you want to handle it in this PR?

@bbatsov bbatsov merged commit 3ecdb73 into master Jan 4, 2019
@bbatsov bbatsov deleted the inspector-features branch January 4, 2019 16:16
@bbatsov
Copy link
Member

bbatsov commented Jan 4, 2019

Thanks!

@bbatsov
Copy link
Member

bbatsov commented Jan 4, 2019

The latest cider-nrepl already includes your changes.

alexander-yakushev added a commit that referenced this pull request Apr 21, 2024
Since I introduced it back in 2019 (see #38), it never got a cider-nrepl op
counterpart and nobody seemed to miss it (and apparently neither did I, lol).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants