-
Notifications
You must be signed in to change notification settings - Fork 786
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CLJS-1483: Minor DCE regression with advanced compilation mode
change :def case in compiler so that we once again only emit if init supplied. The REPL is the only exception. Without the above change foward declarations would prevent DCE. fix minor DCE issue around murmur3 hashing.
- Loading branch information
1 parent
30e302c
commit 1346c3f
Showing
2 changed files
with
57 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swannodette why do we have to prevent emitting
;
for:expr
?If we have two expressions as below,
We will end up getting this error:
I guess, this issue has to be addressed in (eval-str*, compile-str*)