Skip to content

Commit

Permalink
really fix circular dependency error
Browse files Browse the repository at this point in the history
  • Loading branch information
dnolen committed Jan 6, 2016
1 parent 28a7440 commit e807ebf
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/main/clojure/cljs/analyzer.cljc
Original file line number Diff line number Diff line change
Expand Up @@ -1654,7 +1654,10 @@
(binding [*cljs-dep-set* (vary-meta (conj *cljs-dep-set* lib) update-in [:dep-path] conj lib)]
(assert (every? #(not (contains? *cljs-dep-set* %)) deps)
(str "Circular dependency detected, "
(apply str (interpose " -> " (-> *cljs-dep-set* meta :dep-path)))))
(apply str
(interpose " -> "
(conj (-> *cljs-dep-set* meta :dep-path)
(some *cljs-dep-set* deps))))))
(doseq [dep deps]
(when-not (or (not-empty (get-in compiler [::namespaces dep :defs]))
(contains? (:js-dependency-index compiler) (name dep))
Expand Down

0 comments on commit e807ebf

Please sign in to comment.