Growing a DSL - use longs and variable fixes #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It happened in |
michaelklishin
pushed a commit
that referenced
this pull request
Mar 23, 2013
Growing a DSL - use longs and variable fixes
|
Nice catch, thanks for the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I came across the Growing a DSL with Clojure tutorial and it was fantastic, learnt quite a bit from it, especially being new to Clojure.
Only noticed that some of the code wouldn't run in the REPL because of variables being wrong and switching based on Integer's didn't work. I'm guessing earlier versions of Clojure did, then they changed to Long's - not sure.
Cheers.