Initial refactor and rewrite of clojure.java.jdbc docs #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this is awesome. Thank you! @seancorfield can I get your blessing? :) |
|
|
||
| (def db-spec |
There was a problem hiding this comment.
I'm trying to encourage folks to switch to the new, simpler dbtype/dbname format. Could you update the example to this:
(def db-spec
{:dbtype "mysql"
:dbname "mydb"
:user "myaccount"
:password "secret"})
(and the paragraph above will need updating to reflect this preferred approach).
|
It's a huge improvement on what's currently there so BIG "Thanks!" to @ehashman -- I have no other comments beyond switching the introductory |
|
Incoming fix for the db-spec, please hold... |
|
Excellent! @michaelklishin Do you want to trigger a build/deploy of the site? |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #229.
I've not yet had the chance to work on "Using SQL" and "Using DDL". I'll save those changes for a follow-up PR.