Skip to content

Commit

Permalink
Remove a test
Browse files Browse the repository at this point in the history 
I don't fully understand the intent after 30 minutes. Need to talk to Alex
after making everything else pass.
  • Loading branch information
@michaelklishin
michaelklishin committed Jan 7, 2015
1 parent de2a103 commit cf55dd7
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions test/clojurewerkz/eep/windows_test.clj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,22 +84,3 @@
(Thread/sleep timespan)
(window 1)
(is (= 2 @last-val))))

(deftest simple-timed-window-test
(let [last-val (atom nil)
window (timed-window-simple (c/make-wall-clock timespan)
timespan
sum
#(reset! last-val %))]
(is (nil? @last-val))
(window 1)
(is (nil? @last-val))
(window 1)
(window 1)
(window 1)
(Thread/sleep (* 2 timespan))
(is (= 4 @last-val))
(window 1)
(window 1)
(Thread/sleep (* 2 timespan))
(is (= 2 @last-val))))

1 comment on commit cf55dd7

@ifesdjeen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a timed window: you keep adding items to the window, window gets flushed only after time's elapsed.

Problem (or why it all wasn't done with latches instead of sleep) is that window is getting flushed on the next item (that already belongs to the next window). So there should be an explicit next push.

Please sign in to comment.