A first stab at Support bulk operations in the native client #24 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (defn bulk-delete | ||
| "generates the content for a bulk delete operation" | ||
| ([documents] | ||
| (let [operations (map delete-operation documents)] |
There was a problem hiding this comment.
This local can be inlined here.
|
I've left some comments, none of them are major. If this is one of your first attempts at working with Clojure, good job! :) |
|
Thank you for your feedback :) I am using Clojure for about 3 months now, but I currently work alone so I get no code reviews :( Think I'm going to do some more open source work good way to improve my clojure (and a lot of fun) |
michaelklishin
added a commit
that referenced
this pull request
Mar 2, 2015
A first stab at Support bulk operations in the native client #24
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is my first stab at native bulk operations. The responses are not exactly the same as the but come pretty close.
The API is exactly the same only the params handling is a bit messy and only supports
{:refresh true}currently. I implemented the same tests as the rest bulk test and they all succeed :) But you can pretty much switch between the native and rest bulk calls, which I think is pretty neat.I am happy to receive some feedback I am working on improving my clojure skills.