Error after installing plugin

[CashDesk]

I upgraded to 1,11
I added a row with 'Signal::send('ticket.before.delete', $this); // Archiver plugin: Added to archive tickets before deleting them. to the 'class.ticket.php' file.
After this change, i cannot open an existing attachment. I get a windows error that the file is corrupt.
After restoring the original file it works again.

Seems that I did something wrong?

I had the folowing:

function delete($comments='') {
global $ost, $thisstaff;

Signal::send('ticket.before.delete', $this); // Archiver plugin: Added to archive tickets before deleting them.

//delete just orphaned ticket thread & associated attachments.
// Fetch thread prior to removing ticket entry
$t = $this->getThread();

[CashDesk]

@clonemeagain, any idea what i did wrong?

[clonemeagain]

Hey chief, can you post the file with the mod, or should I make a copy you can just slot in there.. that's probably easier. You don't need it for deleting, just archiving. Been meaning to work on it, but super busy.

[CashDesk]

class.ticket.-archive.zip
Here you are and thanks for your help!

[CashDesk]

A copy of your file is also ok!

…

Op 24 mrt. 2019 om 12:55 heeft Aaron ***@***.***> het volgende geschreven: Hey chief, can you post the file with the mod, or should I make a copy you can just slot in there.. that's probably easier. You don't need it for deleting, just archiving. Been meaning to work on it, but super busy. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[CashDesk]

Hi @clonemeagain , did you had time to check it? Thanks for your reply

[clonemeagain]

Dang, totally forgot. I've put it in my calendar for tomorrow mate. Should really check this more.

[clonemeagain]

Ok, I've tested it with 1.11 on PHP 7 and it works. I'm not getting any server errors, well, none related to the plugin, if you crank up the logging it's quite a list to dig through.

https://gist.github.com/clonemeagain/40c4a026d292789375a2caf2c983253d

Generated by modifying bootstrap.php to include an error-handler, ie:

function errorHandler($errno, $errstr, $errfile, $errline) {
 
    switch ($errno) {
        case E_NOTICE:
        case E_USER_NOTICE:
        case E_DEPRECATED:
        case E_USER_DEPRECATED:
        case E_STRICT:
            error_log("STRICT error $errstr at $errfile:$errline n");
            break;
 
        case E_WARNING:
        case E_USER_WARNING:
            error_log("WARNING error $errstr at $errfile:$errline n");
            break;
 
        case E_ERROR:
        case E_USER_ERROR:
        case E_RECOVERABLE_ERROR:
            exit("FATAL error $errstr at $errfile:$errline n");
 
        default:
            error_log("Unknown error at $errfile:$errline n");
    }
}
 
set_error_handler("errorHandler");

You should not do that on production systems, but if you are still having an issue, please enable the logging and send me the link, or email it to me clonemeagain@gmail.com

I've modified the ReadMe and uploaded copies of the Tagged releases with the mod, I think your file is probably right, so it's a mystery. You can try my versions if you like, they are just that one line change from core.

[CashDesk]

@clonemeagain i tried with my file and got the same erros. After that i copied yours and it seems to work now.
Thanks!

[clonemeagain]

Ok cool. :-)