Rename virtualbox VM names to predictable [ci skip] #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I suggest you to add this to make virtualbox vm names more predictable. Now i suspect that virtualbox vm names are slightly random. cfg.vm.provider "virtualbox" do |vb, override| ... vb.name = "name.windomain.local" ... end
|
Let me explain.
|
clong
requested changes
Sep 4, 2018
There was a problem hiding this comment.
Thanks for adding this PR! Two things need to happen before merge:
- Change logger.windomain.local to logger
2.Add v.vmx["displayname"] = $hostname(where $hostname is the name of the host) to the vmware_fusion and vmware_desktop sections so that this stays consistent across VBox and VMware
Vagrant/Vagrantfile
Outdated
| @@ -20,6 +20,7 @@ Vagrant.configure("2") do |config| | |||
|
|
|||
| cfg.vm.provider "virtualbox" do |vb, override| | |||
| vb.gui = true | |||
| vb.name = "logger.windomain.local" | |||
There was a problem hiding this comment.
logger is not part of the domain, and should therefore just be "logger"
dmi3mis
commented
Sep 5, 2018
clong
approved these changes
Sep 5, 2018
|
Looks good, thank you |
clong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I suggest you to add this to make virtualbox vm names more predictable.
Now i suspect that virtualbox vm names are slightly random.
cfg.vm.provider "virtualbox" do |vb, override|
...
vb.name = "name.windomain.local"
...
end