Added position and slide tracking for reveal.js #181
Conversation
prevents too many slide switches
|
Hi! Thanks a lot of this contribution! This works great but as you said the code is a litte rough. Are you interested to work on this a little more? It would be great if most of this code could be moved to the app-static library. Maybe even with some unit tests added. 😄 Some ideas:
Christian |
| { | ||
| if (options->markdownConverter() == Options::RevealMarkdownConverter) { | ||
| ui->webView->page()->mainFrame()->evaluateJavaScript( | ||
| "(function(){" |
There was a problem hiding this comment.
Maybe this javascript code could be put into PresentationTemplate class. See the scrollbar synchronization in HtmlTemplate class for an example.
There was a problem hiding this comment.
I thought about that already. But this would also be part of any html export.
|
Thanks a lot for your feedback. I have not placed the code anywhere special because I do not know where you want to go. (The roadmap is a dead link.) We have:
If we are serious about reveal.js - we need a lot of new abstractions. |
Moved the logic for the line to slide mapping from the MainWindow into the separate SlideLineMapping class and refactored the code to be more "Qt-like". Refactoring of #181
The reveal.js editing feature is promising.
Unfortunatly the preview jumped to the first slide on every edit. And for large presentations it's hard to find the slide in the markdown.
I added both features with this pull request.
The code is a little rough, as everything is done in the mainwindow. But the functionality is there and works.