Slide position tracking for Reveal.js and refactor scrollbar synchronization #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents too many slide switches
…ithub.com/hicknhack-software/CuteMarkEd into hicknhack-software-feature/reveal.js_slide_position_tracking
Moved the logic for the line to slide mapping from the MainWindow into the separate SlideLineMapping class and refactored the code to be more "Qt-like". Refactoring of #181
Add lineForSlide() method that returns the line number for the passed slide and use it in MainWindow. In template_presentation.html we setup the slide separator to be surrounded by empty lines. The logic in SlideLineMapping is adapted accordingly and new unit test were added.
Add slideForLine() method to the SlideLineMapping class. It returns the slide for the passed line number.
A ViewSynchronizer implementation is responsible to keep the Markdown editor and the HTML preview in sync regarding its position. Currently there is just the RevealViewSynchronizer implementation for this base class. Refactor the MainWindow class and move all code regarding the view synchronization to the RevealViewSynchronizer class.
Add implementation of ViewSynchronizer class that synchronizes the Markdown editor with the HTML preview and move the code from MainWindow class to HtmlViewSynchronizer class.
cloose
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring ideas for PR #181.