This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Python3 support #95
Closed
Python3 support #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python3 support
updated test to python3
thomasst
reviewed
Sep 26, 2016
| @@ -14,29 +17,35 @@ def __call__(self): | |||
|
|
|||
| def prepare_queryset_kwargs(self, field, value, negate): | |||
| if negate: | |||
| return {'__'.join(filter(None, [field, 'not', self.op])): value} | |||
| return {'__'.join([_f for _f in [field, 'not', self.op] if _f]): value} | |||
There was a problem hiding this comment.
filter still exists in Python 3.5.2, why change? https://docs.python.org/3/library/functions.html#filter
There was a problem hiding this comment.
I used 2to3 library, the library converts this specific implementation of filters.
thomasst
reviewed
Sep 26, 2016
| self.assertEqual(errors['field-errors'].keys(), ['emails']) | ||
| self.assertEqual(errors['field-errors']['emails']['errors'].keys(), ['1', '3']) | ||
| self.assertEqual(list(errors['field-errors'].keys()), ['emails']) | ||
| self.assertCountEqual(list(errors['field-errors']['emails']['errors'].keys()), ['3', '1']) |
There was a problem hiding this comment.
Good catch, keep in mind that assertCountEqual was only added in Python 3.2 and therefore would break Python 2.7 compatibility. I'll fix this by simply doing a set() comparison.
Merged
|
@saurabh1e Thanks for this. I prepared #99 based on this. Let me know if anything is missing there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.