This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Support for Python 3 / latest MongoEngine #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@closeio/engineering please review (app tests pass as well) |
This was referenced Sep 28, 2016
Closed
|
LGTM
If we don't/can't push that upstream, maybe we could put those in a separate lib/repo like "mongoengine-addons" which will work with both our fork and upstream mongoengine and depend on that? |
We'll have to do some more work before we do that – right now our changes don't merge in cleanly into the upstream MongoEngine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tested on:
Note that I skipped two tests since upstream MongoEngine doesn't have certain features like
SafeReferenceField.