Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a DecimalField #20

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Include a DecimalField #20

merged 1 commit into from
Apr 23, 2019

Conversation

mpessas
Copy link

@mpessas mpessas commented Apr 22, 2019

This uses a string to store the value in MongoDB, contrary to what upstream
does. This makes sure we do not lose any precision.

Copy link
Member

@wojcikstefan wojcikstefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mongoengine/fields.py Outdated Show resolved Hide resolved
This uses a string to store the value in MongoDB, contrary to what upstream
does. This makes sure we do not lose any precision.
@mpessas mpessas merged commit e370ec3 into master Apr 23, 2019
@mpessas mpessas deleted the include-decimal-field branch April 23, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants