-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage for injector_helper #44
Comments
Is 58% the best we can have with integration tests? Does CI support IPv6? Why isn't the DHT joining code running? I think we could do a lot more. |
Currently the tests don't use DHT. Instead I did it this way because:
(1) could potentially be solved by solving issue #13. (2) is a bit trickier. I think Travis CI workers are not behind a NAT, not 100% sure though. In such case it would work there. For people behind a NAT though, the test would work only if they:
I think I'd first try the fourth option...
I'll check, but does |
There's some untested IPv6 code. Do we need it? If yes, let's cover; if not, let's remove? |
AFAIK, that is really only three lines here and here (both are a copy/paste from here). We don't necessarily NEED it as it seems But even if we did add it, I haven't yet checked whether Travis supports IPv6, so we still may not be able to cover it with tests. |
Just to have a complete picture: It seems the OSX Travis workers do have a support for IPv6, while Linux workers don't. OSX:
Linux:
Adding a support for IPv6 however would seem like a task in itself. Here are the courses of action I can see, @shalunov please let me know which one you prefer:
|
Coverage increase in injector_helper (resolves #44)
To better understand what we'll need to do to get good test coverage, let's start with injector helper.
The text was updated successfully, but these errors were encountered: