Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding logic to backpack to only run on a node once for a given uuid #315

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Adding logic to backpack to only run on a node once for a given uuid #315

merged 1 commit into from
Apr 28, 2020

Conversation

dry923
Copy link
Member

@dry923 dry923 commented Apr 21, 2020

Note: This needs to be merged after cloud-bulldozer/bohica#10 and cloud-bulldozer/metadata-collector#3

This will add the ability for backpack to only run on a node once per each uuid. So if 3 pods land on the same node for the same workload it will only collect the data once. The init container will still run and then complete with a message saying that the data was already collected.

@stale stale bot removed the not_ready label Apr 22, 2020
@dry923 dry923 force-pushed the backpack_check_node branch 3 times, most recently from 6d40b5b to e221891 Compare April 22, 2020 18:00
dry923 added a commit to dry923/plow that referenced this pull request Apr 22, 2020
@dry923
Updating metadata collection definition for cloud-bulldozer/benchmark…
94565c4 
…-operator#315
@dry923 dry923 mentioned this pull request Apr 22, 2020
Merged
jtaleric
jtaleric reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single nit...

roles/backpack/templates/backpack.yml Outdated Show resolved Hide resolved
@dry923 dry923 added the ok to test Kick off our CI framework label Apr 23, 2020
@dry923
Copy link
Member Author

dry923 commented Apr 23, 2020

/rerun all

@rht-perf-ci
Copy link

Results for crc_jjb

Test Result Retries Duration (HH:MM:SS)

@dry923
Copy link
Member Author

dry923 commented Apr 23, 2020

/rerun all

@rht-perf-ci
Copy link

Results for crc_jjb

Test Result Retries Duration (HH:MM:SS)

@dry923
Copy link
Member Author

dry923 commented Apr 23, 2020

/rerun all

@rht-perf-ci
Copy link

Results for crc_jjb

Test Result Retries Duration (HH:MM:SS)

@dry923
Copy link
Member Author

dry923 commented Apr 23, 2020

/rerun all

@rht-perf-ci
Copy link

Results for crc_jjb

Test Result Retries Duration (HH:MM:SS)
test_backpack Pass 0 00:01:57
test_byowl Pass 0 00:02:32
test_fiod Pass 0 00:14:07
test_fs_drift Pass 0 00:05:10
test_hammerdb Pass 0 00:03:48
test_iperf3 Pass 0 00:03:11
test_pgbench Pass 0 00:02:00
test_smallfile Pass 0 00:06:21
test_sysbench Pass 1 00:04:31
test_uperf Pass 0 00:16:52
test_ycsb Pass 0 00:01:37

@dry923 dry923 mentioned this pull request Apr 24, 2020
Closed
jtaleric
jtaleric approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, still fearful, but LGTM!

rsevilla87
rsevilla87 reviewed Apr 28, 2020
View reviewed changes
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @dry923 , I added just a few comments.

docs/metadata.md Outdated Show resolved Hide resolved
docs/metadata.md Show resolved Hide resolved
docs/metadata.md Outdated Show resolved Hide resolved
roles/byowl/templates/workload.yml Show resolved Hide resolved
@dry923
Adding logic to backpack to only run on a node once for a given uuid.…
a82ab0f 
… Additionally, converted metadata_* variables to an object metadata.*
@rsevilla87 rsevilla87 self-requested a review April 28, 2020 15:07
rsevilla87
rsevilla87 approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rht-perf-ci
Copy link

Results for crc_jjb

Test Result Retries Duration (HH:MM:SS)
test_backpack Pass 0 00:01:41
test_byowl Pass 0 00:01:36
test_fiod Pass 0 00:12:35
test_fs_drift Pass 0 00:04:54
test_hammerdb Pass 0 00:03:48
test_iperf3 Pass 0 00:03:38
test_pgbench Pass 0 00:02:03
test_smallfile Pass 0 00:05:29
test_sysbench Pass 0 00:01:50
test_uperf Pass 0 00:17:15
test_ycsb Pass 0 00:01:44

@rsevilla87 rsevilla87 merged commit 2174e38 into cloud-bulldozer:master Apr 28, 2020
@aakarshg aakarshg mentioned this pull request May 1, 2020
Closed
jtaleric pushed a commit to cloud-bulldozer/e2e-benchmarking that referenced this pull request May 1, 2020
@dry923 @jtaleric
Updating metadata collection definition for cloud-bulldozer/benchmark…
ef76f09 
…-operator#315
vishnuchalla pushed a commit to cloud-bulldozer/e2e-benchmarking that referenced this pull request Sep 6, 2023
@dry923 @jtaleric
Updating metadata collection definition for cloud-bulldozer/benchmark…
063de79 
…-operator#315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtaleric jtaleric jtaleric approved these changes

@rsevilla87 rsevilla87 rsevilla87 approved these changes

@aakarshg aakarshg aakarshg approved these changes

@bengland2 bengland2 Awaiting requested review from bengland2

Assignees
No one assigned
Labels
ok to test Kick off our CI framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dry923 @rht-perf-ci @jtaleric @rsevilla87 @aakarshg