Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recommendations page in integration tests #959

Closed
camcash17 opened this issue Nov 3, 2022 · 1 comment
Closed

Fix recommendations page in integration tests #959

camcash17 opened this issue Nov 3, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@camcash17
Copy link
Collaborator

After recent changes to the API, the integration tests are failing on the recommendations page, where currently there are actual requests being sent to the cloud API's instead of using mock data.

@camcash17 camcash17 created this issue from a note in Cloud Carbon Footprint project board (Ready To Do (priority order)) Nov 3, 2022
@camcash17 camcash17 added the bug Something isn't working label Nov 3, 2022
@tinamthomas
Copy link
Contributor

tinamthomas commented Nov 8, 2022

I looked into this a little bit since the tests were passing for me locally despite this issue.

From what I can see of the the code, it looks like there's a test mode in the app.ts file for recommendations, to ensure it sends mock data (See here)

And the app that's started for the integration test seems to be setting the env variable correctly (See here)


UPDATE:
The reason they were passing for me but failing for others was because I do not have configurations for AWS/GCP/Azure set up.

tinamthomas added a commit to tinamthomas/cloud-carbon-footprint that referenced this issue Nov 9, 2022
@mvaltas mvaltas closed this as completed Nov 10, 2022
Cloud Carbon Footprint project board automation moved this from Ready To Do (priority order) to Done Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants