Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#818] Integration tests added to CI #961

Merged
merged 5 commits into from
Nov 9, 2022

Conversation

tinamthomas
Copy link
Contributor

@tinamthomas tinamthomas commented Nov 4, 2022

Description of Change

Issue #818 changes

  1. assertionTimeout and selectorTimeout set to 5 seconds instead of default 3 seconds
  2. added step in CI to run integration tests (With ContinueOnError = true, so that we can monitor tests to ensure they pass consistently without disrupting development effort. Then we can remove this flag.

Issue #832 changes: Local hanging issue resolved based on discussion here jeffbski/wait-on#116

Issue #959 changes: Needed mock data to be returned in the emissions API, using TEST_MODE flag to know if mocking is needed

Checklist

  • PR description included and stakeholders cc'd
  • tests are changed or added
  • yarn test passes
  • yarn lint has been run
  • git pre-commit hook is successfully executed.
    (Please refrain from using --no-verify)
  • yarn changeset was run and relevant packages have been updated as a major/minor/patch bump with descriptions
    (Determine version update using Semantic Versioning)
  • relevant documentation is changed or added

Notes

© 2021 Thoughtworks, Inc.

@tinamthomas tinamthomas marked this pull request as ready for review November 4, 2022 15:52
@tinamthomas tinamthomas marked this pull request as draft November 4, 2022 15:53
@camcash17
Copy link
Collaborator

Please take a look at Issue #959 before completing this PR

@tinamthomas
Copy link
Contributor Author

Absolutely @camcash17. Was going to look into it, but ran into this issue and wanted to address that first. #832

@tinamthomas tinamthomas marked this pull request as ready for review November 9, 2022 18:04
Copy link
Member

@4upz 4upz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and passes on my machine! Thanks for working on this! 🥳

@4upz 4upz merged commit 222bfed into cloud-carbon-footprint:trunk Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants