Fix Bug #3429 on securityhub finding id tagging #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull changes from upstream
kapilt
reviewed
Jan 25, 2019
| @@ -220,7 +220,7 @@ def process(self, resources, event=None): | |||
| 'title', self.manager.ctx.policy.name)), | |||
| 'value': '{}:{}'.format( | |||
| finding['Id'], created_at)}, | |||
| self.manager).process(resources) | |||
| self.manager).process(resource_set) | |||
There was a problem hiding this comment.
ugh, i think i saw this go by one in one of the prs.
kapilt
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this code will now tag resources with the right finding id, any resources already tagged with finding id will still suffer from last batch wins (overwrites any previous imports with same findingid. Thus users need to untag those resources, or we would need to force a change to the formation of the findingid so there are different.