aws.fsx - add kms-key filter to fsx resource #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisshi
reviewed
Jan 31, 2019
| session_factory=session_factory, | ||
| ) | ||
| resources = p.run() | ||
| self.assertEqual(len(resources), 1) |
There was a problem hiding this comment.
you should be asserting that the resource that was returned was the one you're expecting, not just that there was a single resource filtered in.
There was a problem hiding this comment.
verifying the annotation is a good sanity check, that the related filter was invoked.
thisisshi
changed the title
|
Also, while you're at it can you add this filter to the fsx-backup resource as well, it has a KmsKeyId reference as well |
|
Implemented the review comments and pushed the updates. Can you please check @thisisshi and @kapilt ? |
kapilt
approved these changes
Jan 31, 2019
lamyanba
pushed a commit
to lamyanba/cloud-custodian
that referenced
this pull request
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding KMS filter in the FSX resource. We need this to enable encryption .