Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure - fix applicationinsights functions packaging #4434

Merged
merged 3 commits into from
Jul 24, 2019
Merged

azure - fix applicationinsights functions packaging #4434

merged 3 commits into from
Jul 24, 2019

Conversation

aluong
Copy link
Collaborator

@aluong aluong commented Jul 24, 2019

  • We are not properly handling the case where one dependency's name was a substring of another dependency. Ex: applicationinsights is a substring of azure-mgmt-applicationinsights
  • Explicitly added applicationinsights into the setup.py
  • removed the pinning of applicationinsights

@aluong aluong changed the title [WIP] azure - fix applicationinsights functions packaging azure - fix applicationinsights functions packaging Jul 24, 2019
@aluong aluong merged commit 8b0638d into cloud-custodian:master Jul 24, 2019
alexkarpitski pushed a commit to mediapills/cloud-custodian that referenced this pull request Jul 29, 2019
@aluong
azure - fix applicationinsights functions packaging (cloud-custodian#…
3919928 
…4434)
fidelito pushed a commit to fidelito/cloud-custodian that referenced this pull request May 29, 2020
@aluong @fidelito
azure - fix applicationinsights functions packaging (cloud-custodian#…
8622378 
…4434)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logachev logachev logachev approved these changes

@stefangordon stefangordon Awaiting requested review from stefangordon

Assignees
No one assigned
Labels
provider/azure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aluong @logachev