aws.ecs | deregister container instances and delete clusters

[PratMis]

Closes #5039

This PR adds two actions for ecs-clusters:

1. deregister-container-instances: lets you deregister container instances. force option can be used as per boto docs: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecs.html#ECS.Client.deregister_container_instance

2. delete: lets you delete ecs cluster. force: true, deregisters container instances followed by cluster deletion. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecs.html#ECS.Client.delete_cluster
   This also cleans up any ecs managed capacity provider(asgs)

[PratMis]

I'll add one more test to delete ecs cluster with force: false to bump up codecov

[PratMis]

thanks @kapilt , I have addressed all findings as per your suggestion

[PratMis]

Had to add one more test to keep the codecov up!!

[kapilt]

thanks, looks good, one thing that came up in wrt to eks delete is actually deleting the underlying compute instances/asg. any thoughts on that? I'm not really clear on the use case here so would appreciate if thats something you feel is also of interest (also making an assumption this is something your planning on using?).

[PratMis]

Thanks for pointing it out! Yes, this is something we would be using! I'll add the deletion of underlying instances as part of cluster cleaning process in this Pr!

[PratMis]

@kapilt I was thinking of adding the deletion of underlying instance as a part of action: deregister-instance and reusing the code in delete action. Policy sample:

name: ecs-instances
resource: ecs
filters:
  - type: x
actions:
  - type: deregister-instance
     delete-instances: true

Let me know if this sounds good to you? Thanks!!

[kapilt]

@kapilt I was thinking of adding the deletion of underlying instance as a part of action: deregister-instance and reusing the code in delete action. Policy sample:

name: ecs-instances
resource: ecs
filters:
  - type: x
actions:
  - type: deregister-instance
     delete-instances: true

Let me know if this sounds good to you? Thanks!!

sounds good

[PratMis]

@kapilt I was thinking of adding the deletion of underlying instance as a part of action: deregister-instance and reusing the code in delete action. Policy sample:

name: ecs-instances
resource: ecs
filters:
  - type: x
actions:
  - type: deregister-instance
     delete-instances: true

Let me know if this sounds good to you? Thanks!!

sounds good

While implementing I realized that it might be better a better approach to keep the instance deletion action as part of the cluster cleanup because there might be other things like ASGs etc as part of underlying instance. Already made the code changes last night. If you feel it would be better to stick with the first approach, more than happy to make the changes. Thank you!

[kapilt]

i'm more concerned with that these are asg instances, and this will just cause churn instead of providing value. if the ecs cluster per its capacity provider is managing the asg that seems safe to delete. if for whatever reason the asg is spanning clusters.. that would be problematic, distinction here is wholly owned asg for the cluster vs one thats shared, not that would be a good idea, but part of custodian is saving people from making accidentally making bad choices that make things worse, when its non obvious that is the outcome.

[PratMis]

Understood! I have added code to delete ecs managed asgs if any on cluster deletion with force: true. Your feedback was really helpful. Thanks so much!!

[nomecks]

Has there been any movement on this? My company has been waiting for this functionality to manage sandbox and non-production cluster sprawl.

[PratMis]

hey @nomecks , sorry for the delay. I'll try to fix this PR today as per the feedback received from @kapilt

[nomecks]

We'd still love to have this functionality!

[nomecks]

Giving this a bi-monthly bump

[vauchok]

Hi all,

Any, updates? I think this functional would really helpful for cleaning policies.

Thanks

[PratMis]

Hey, apologies on this one. I'll get back to it this week

[kpalaparthi]

Hi,
When we expect this functionality. We are looking for ECS termination and deregister of task definitions.
can someone please let us know when this functionality can be expected