-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure nested management group support #5672
Conversation
This is great. There is at least one test in If it is just that one test you won't have to mess with VCR recordings because it patches the API rather than using HTTP playback. You'll just need to update the patch attribute and fix the test. FYI @logachev I think he worked on this originally. |
@JS-Jake Thanks for the pull request! If you don't mind could you sign the CLA per the developer docs? Direct link here: https://docs.google.com/forms/d/e/1FAIpQLSfwtl1s6KmpLhCY6CjiY8nFZshDwf_wrmNYx1ahpsNFXXmHKw/viewform |
@stefangordon Thank you, I'll take a look at that but might need a little help |
@JS-Jake I went ahead and updated the test, thanks again for the pull request. |
@kapilt Awesome, thanks for the help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
This change allows custodian instances using Azure Functions to access subscriptions inside nested management groups. eg: