Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure nested management group support #5672

Merged
merged 3 commits into from
May 9, 2020
Merged

Azure nested management group support #5672

merged 3 commits into from
May 9, 2020

Conversation

JS-Jake
Copy link
Contributor

@JS-Jake JS-Jake commented Apr 29, 2020

This change allows custodian instances using Azure Functions to access subscriptions inside nested management groups. eg:

  • Parent Management Group
    • Management Group 1
      • Subscription 1
    • Management Group 2
      • Management Group 3
        • Subscription 2

JS-Jake and others added 2 commits April 29, 2020 13:47
* recursive management group search
@stefangordon
Copy link
Collaborator

stefangordon commented Apr 29, 2020

This is great. There is at least one test in c7n_azure/tests_azure/test_azure_utils.py that will have to be updated. (test_managed_group_helper)

If it is just that one test you won't have to mess with VCR recordings because it patches the API rather than using HTTP playback. You'll just need to update the patch attribute and fix the test.

FYI @logachev I think he worked on this originally.

@kapilt
Copy link
Collaborator

kapilt commented Apr 29, 2020

@JS-Jake Thanks for the pull request! If you don't mind could you sign the CLA per the developer docs? Direct link here: https://docs.google.com/forms/d/e/1FAIpQLSfwtl1s6KmpLhCY6CjiY8nFZshDwf_wrmNYx1ahpsNFXXmHKw/viewform

@kapilt kapilt requested a review from logachev April 29, 2020 17:12
@JS-Jake
Copy link
Contributor Author

JS-Jake commented Apr 30, 2020

@stefangordon Thank you, I'll take a look at that but might need a little help
@kapilt All done :)

@kapilt
Copy link
Collaborator

kapilt commented May 9, 2020

@JS-Jake I went ahead and updated the test, thanks again for the pull request.

@kapilt kapilt removed the request for review from logachev May 9, 2020 12:30
@JS-Jake
Copy link
Contributor Author

JS-Jake commented May 9, 2020

@kapilt Awesome, thanks for the help

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit 59d143c into cloud-custodian:master May 9, 2020
fidelito pushed a commit to fidelito/cloud-custodian that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants