tests - gracefully handle non-default aws/git config #7057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `make test-poetry` processes `test.env` before running tests. Unset an `AWS_PROFILE` environment variable if it exists. * c7n-policystream tests initialize a local git repo and make assumptions about the local git client's `init.defaultBranch` setting. Explicitly use `main` during initialization and testing.
|
this seemed to cause some breakage on trunk for policy stream testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a couple minor test breakages I saw locally due to custom config options for the AWS CLI and git. The changes should be transparent for CI/release but help avoid brittleness for other contributors. Alternative suggestions welcome though!
make test-poetrysourcestest.envbefore running tests. Unsetan
AWS_PROFILEenvironment variable if it exists.c7n-policystream tests initialize a local git repo and make
assumptions about the local git client's
init.defaultBranchsetting.Explicitly use
mainduring initialization and testing.