aws - quotas - include aws default service quotas #7572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
reviewed
Jul 28, 2022
kapilt
approved these changes
Aug 9, 2022
kentnsw
reviewed
Aug 10, 2022
| q['QuotaCode']: q | ||
| for q in _get_quotas(client, s, 'list_service_quotas') | ||
| } | ||
| quotas.update(dquotas) |
There was a problem hiding this comment.
@thisisshi
Please reconsider using the other way around. This morning I received some alerts from my accounts, and I thought our business team must be working on a big project. 🤣 It uses the default value rather than the applied quota value. See below for an example. The Quota is a default one, the applied one is 1000+.
Service Quota - service usage > 80% - [my-awsome-account - ap-southeast-2]
ServiceName: Amazon Elastic Compute Cloud (Amazon EC2)
QuotaName: Running On-Demand Standard (A, C, D, H, I, M, R, T, Z) instances
Quota: 5.0
Usage: 325.0
There was a problem hiding this comment.
Here is my version, so far so good.
newscorp-ghfb#127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to rerecord the tests, but this policy before would not match but now does with this change: