Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c7n_tencentcloud - Add environment fixture, and add 'qcs' to resources. #7818

Closed
wants to merge 2 commits into from

Conversation

howbazaar
Copy link
Collaborator

Environment fixture means that the tests can run on a clean checkout.
Adds 'qcs' as a resource key as part of the resource description.

@howbazaar howbazaar changed the title Add environment fixture, and add 'qcs' to resources. c7n_tencentcloud - Add environment fixture, and add 'qcs' to resources. Sep 30, 2022
@@ -182,7 +187,7 @@ def get_resource_qcs(self, resources):
get_resource_qcs
resource description https://cloud.tencent.com/document/product/598/10606
"""
# qcs::${ServiceType}:${Region}:${Account}:${ResourcePreifx}/${ResourceId}
# qcs::${ServiceType}:${Region}:${Account}:${ResourcePrefix}/${ResourceId}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by typo fix

@@ -280,7 +285,7 @@ def resources(self):
params = self.get_resource_query_params()
resources = self.source.resources(params)

# filter resoures
# filter resources
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here.

@howbazaar
Copy link
Collaborator Author

Closing, test fixture superseded by #7824, and deferring qcs in resources to #7809

@howbazaar howbazaar closed this Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant