c7n_tencentcloud: add fixture for environment variables, and fix typos in query.py. #7824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howbazaar
force-pushed
the
tencent-tests
branch
from
e56fd60
to
f28a7a0
Compare
kapilt
reviewed
Oct 3, 2022
| @@ -7,6 +7,13 @@ | |||
| from c7n_tencentcloud.client import Session | |||
|
|
|||
|
|
|||
| @pytest.fixture(autouse=True) | |||
There was a problem hiding this comment.
we currently do this in test.env file across all providers. which is used by the make test-poetry target. I do wonder if we should switch to this style of fixture at least for this provider to make testing in isolation easier. I think part of the issue re a general switch is that other providers also have unit test cases which don't normally support pytest fixtures.
ritch2022
pushed a commit
to ritch2022/cloud-custodian
that referenced
this pull request
Oct 13, 2022
HappyKid117
pushed a commit
to HappyKid117/cloud-custodian
that referenced
this pull request
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.