fix: get subnet_ids from all interfaces on an EC2 instance #8500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-dranser
force-pushed
the
bugfix/subnet-filter
branch
from
71a4033
to
066de39
Compare
ajkerrigan
approved these changes
Apr 18, 2023
An EC2 instance may have multiple network interfaces where each interface may be deployed in different subnets. As a result, EC2 instance is available in multiple subnets so that we have to check all of them in 'subnet' filter, not only default one Use Case: Need to make sure that EC2 instances is not deployed in public subnets. In that case, we have to check both primary and secondary interfaces because some of them may be deployed in a public subnet.
paladin-dranser
force-pushed
the
bugfix/subnet-filter
branch
from
066de39
to
8ca8ed2
Compare
|
Hi @ajkerrigan, |
ajkerrigan
approved these changes
Apr 19, 2023
ajkerrigan
force-pushed
the
bugfix/subnet-filter
branch
from
c3e9ba8
to
9250da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An EC2 instance may have multiple network interfaces where each
interface may be deployed in different subnets.
As a result, EC2 instance is available in multiple subnets so
that we have to check all of them in 'subnet' filter, not only
default one
Use Case:
Need to make sure that EC2 instances is not deployed
in public subnets. In that case, we have to check both
primary and secondary interfaces because some of them may be
deployed in a public subnet.