Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get subnet_ids from all interfaces on an EC2 instance #8500

Merged
merged 3 commits into from
Apr 19, 2023

Commits on Apr 18, 2023

  1. Configuration menu
    Copy the full SHA
    eddcde3 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. fix: get subnet_ids from all interfaces on an EC2 instance

    An EC2 instance may have multiple network interfaces where each
    interface may be deployed in different subnets.
    As a result, EC2 instance is available in multiple subnets so
    that we have to check all of them in 'subnet' filter, not only
    default one
    
    Use Case:
    
    Need to make sure that EC2 instances is not deployed
    in public subnets. In that case, we have to check both
    primary and secondary interfaces because some of them may be
    deployed in a public subnet.
    paladin-dranser committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    8ca8ed2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9250da5 View commit details
    Browse the repository at this point in the history