Skip to content

Commit

Permalink
Merge pull request #95 from cloud-gov/fix-boto3-version
Browse files Browse the repository at this point in the history
reverted empty argument and updated tests for add_listener_certificates
  • Loading branch information
rcgottlieb committed Feb 13, 2024
2 parents 7fabf36 + e631d75 commit b0fadad
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion renewer/tasks/alb.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def associate_certificate(session, operation_id: int, route_type: RouteType):

alb.add_listener_certificates(
ListenerArn=route_alb.listener_arn,
Certificates=[{"CertificateArn": certificate.iam_server_certificate_arn}, ],
Certificates=[{"CertificateArn": certificate.iam_server_certificate_arn}],
)


Expand Down
10 changes: 5 additions & 5 deletions tests/lib/fake_alb.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ class FakeALB(FakeAWS):
def expect_get_certificates_for_listener(
self, listener_arn, num_certificates=0, add_cert_arn=None
):
certificates = [{"CertificateArn": "certificate-arn", "IsDefault": True}]
certificates = [{"CertificateArn": "certificate-arn"}]
if add_cert_arn is not None:
certificates.append({"CertificateArn": add_cert_arn, "IsDefault": False})
certificates.append({"CertificateArn": add_cert_arn})
for i in range(num_certificates):
certificates.append(
{"CertificateArn": f"certificate-arn-{i}", "IsDefault": False}
{"CertificateArn": f"certificate-arn-{i}"}
)
self.stubber.add_response(
"describe_listener_certificates",
Expand All @@ -27,8 +27,8 @@ def expect_add_certificate_to_listener(self, listener_arn, iam_cert_arn):
"add_listener_certificates",
{
"Certificates": [
{"CertificateArn": "arn:2", "IsDefault": True},
{"CertificateArn": iam_cert_arn, "IsDefault": False},
{"CertificateArn": "arn:2"},
{"CertificateArn": iam_cert_arn},
]
},
{
Expand Down

0 comments on commit b0fadad

Please sign in to comment.