Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverted empty argument and updated tests for add_listener_certificates #95

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

rcgottlieb
Copy link
Contributor

Changes proposed in this pull request:

  • updated tests to remove isDefault as it's not needed
  • removed empty arg

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@rcgottlieb rcgottlieb requested a review from a team February 13, 2024 16:26
@rcgottlieb rcgottlieb merged commit b0fadad into main Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants