Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipeline #63

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Fix pipeline #63

merged 2 commits into from
Jul 6, 2023

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • Fix branch name
  • Update gitignore

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@markdboyd markdboyd requested a review from a team July 6, 2023 14:58
JasonTheMain
JasonTheMain approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@markdboyd markdboyd merged commit 1bc9c6f into main Jul 6, 2023
1 check passed
@markdboyd markdboyd deleted the fix-pipeline branch July 6, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonTheMain JasonTheMain JasonTheMain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdboyd @JasonTheMain