-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Build Logs view to show alert when build logs are over 180 days #4379
Comments
After looking at how this works, I'd like to ask your thoughts, @apburnes and @sknep: Current UX: Right now, the build logs screen shows the "This build does not have any build logs." message initially, replacing that with the actual build logs once they load — if they load. Intended UX: I was going to add an alternate message — "Builds more than 180 days old are deleted according to platform policy." — displayed if But the SiteBuildLogs component does not otherwise have or need the build object itself, just the build id and — if they exist and are returned by the API — the logs. Option 1: Don't check the date at all and just include the 180 day text at the end of the existing message. Option 2: Have the SiteBuildLogs component retrieve the build just so it can check the date. But CommitSummary component, which is included on this page, already retrieves and uses the build as a state object. So I think these sorts of things become possible: Option 3: Modify CommitSummary to take a callback function through which it can pass the build date to SiteBuildLogs once this is retrieved. Option 4: Move the build state and retrieval up to the parent component so that it can be shared. However, either of these options would change the way CommitSummary is used so the build tasks code would be affected as well. What do you think? Option 1 is easy, but affects the UX by including the 180 day text in cases where it may not be relevant. Options 2, 3, and 4 allow for a more precise message, at the cost of changed complexity. |
I like options 3 and 4 the best. Having the default text even on load be "there are no logs" isn't great. Ideally there'd be a "Loading logs..." until we know whether logs would have been found, and then it would change to
Would be interested in looking closer at this with you if you like. |
When a user navigates to build logs over 180 days, display an alert that build logs over 180 days are deleted based on platform policy
Acceptance Criteria
The text was updated successfully, but these errors were encountered: