virtio-devices: block: Make latency infinite before first op #5712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logically until we have handled the first operation the latency is infinite; this logic was applied to the minimum latency originally but this patch extends that logic to the maximum and average latency. To prevent the initial average latency being skewed by the inclusion of infinity the average value is initally seeded with the first measured latency. Fixes: cloud-hypervisor#5704 Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
rbradford
force-pushed
the
2023-08-29-make-latency-infinite-before-data-processed
branch
from
1f0be41
to
9474d93
Compare
likebreath
approved these changes
Aug 29, 2023
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this pull request
Sep 7, 2023
There is a "LATENCY_SCALE" being used for calculating cumulative average latency, so it should also be used for the latency of the first op. See: cloud-hypervisor#5712 Signed-off-by: Bo Chen <chen.bo@intel.com>
This was referenced Sep 7, 2023
rbradford
pushed a commit
that referenced
this pull request
Sep 7, 2023
There is a "LATENCY_SCALE" being used for calculating cumulative average latency, so it should also be used for the latency of the first op. See: #5712 Signed-off-by: Bo Chen <chen.bo@intel.com>
likebreath
added a commit
to likebreath/cloud-hypervisor
that referenced
this pull request
Sep 11, 2023
See: cloud-hypervisor#5712 Signed-off-by: Bo Chen <chen.bo@intel.com>
rbradford
pushed a commit
that referenced
this pull request
Sep 11, 2023
See: #5712 Signed-off-by: Bo Chen <chen.bo@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logically until we have handled the first operation the latency is
infinite; this logic was applied to the minimum latency originally but
this patch extends that logic to the maximum and average latency.
To prevent the initial average latency being skewed by the inclusion of
infinity the average value is initally seeded with the first measured
latency.
Fixes: #5704
Signed-off-by: Rob Bradford rbradford@rivosinc.com