Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio-devices: block: Correct the latency for the first op #5750

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

likebreath
Copy link
Member

There is a "LATENCY_SCALE" being used for calculating cumulative average latency, so it should also be used for the latency of the first op.

See: #5712

There is a "LATENCY_SCALE" being used for calculating cumulative average
latency, so it should also be used for the latency of the first op.

See: cloud-hypervisor#5712

Signed-off-by: Bo Chen <chen.bo@intel.com>
@likebreath likebreath requested a review from a team as a code owner September 7, 2023 17:41
@likebreath
Copy link
Member Author

@praveen-pk Can you please try this PR and see if it solves your issue #5745?

Copy link
Member

@rbradford rbradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change - I misunderstood what this was for, I thought it was a scaling factor to weight the rolling average not a unit scaling.

@rbradford rbradford merged commit e2db476 into cloud-hypervisor:main Sep 7, 2023
21 checks passed
@likebreath likebreath added the bug-fix Bug fix to include in release notes label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Bug fix to include in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants