-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle default
bootloader entry patterns correctly
#188
Handle default
bootloader entry patterns correctly
#188
Conversation
@benmaddison Looks like a great start. I'm very happy with what you've done so far. Some minor things:
On the "slice_take" thing. I don't know ... do you think it's on a path for staying around or might be dropped...it seems quite a stale nightly feature with not much activity. I would also prefer to fix the broken OS support right now than perhaps addressing missing feature gaps unless they are in active use (that could be in a follow-up!) |
Yup - I plan to rebase and squash before asking for a final review
I'm not sure that I know the answer to that. I'll take another look at it to see if I can re-implement that loop without loosing too much readability.
Ack. Agreed. |
Signed-off-by: Ben Maddison <benm@workonline.africa>
Implement matching of boot entry names against the pattern in the default option from `loader/loader.conf`. Signed-off-by: Ben Maddison <benm@workonline.africa>
2f84b73
to
21bc30b
Compare
Open issues for review:
|
I would love to test with this an integration test? Is there a cloud image I can use?
👍
👍 I don't think we need to worry about dealing with a corrupt FAT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really happy with this. Just some very minor nits.
Signed-off-by: Ben Maddison <benm@workonline.africa>
I have To ensure that doesn't happen to future contributors (incl. me), I have dropped an empty |
The NixOS image that I was using when I found the issue is locally generated, and the downloadable ones ship with grub. I've had a search around for other options. So far I've checked ubuntu, fedora and arch: they all use grub :-( I think the best I can offer is to generate a minimal nixos one, and store it in the repo with LFS, but it will make cloning unpleasant. |
Ah, cool. |
Resolves #183
This update implements matching of boot entry names against the pattern in the
default
option fromloader/loader.conf
, intended to be compatible with thebehaviour of
systemd-boot
.Outstanding work
[..]
style patterns - deferred. Tracked in support for[..]
patterns in loader default entry patterns #191slice_take
feature