Switch to using rust-vmm's vhost and vm-virtio #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuestMemoryAtomic enables support for mutable memory maps, and also acts as a convenient wrapper around GuestMemory without its lifetime restrictions. Signed-off-by: Sergio Lopez <slp@redhat.com>
The VHOST_USER_SET_VRING_BASE message is only intended to update the index for the next descriptor in the available ring. Signed-off-by: Sergio Lopez <slp@redhat.com>
The main change is that Queue now requires a type parameter of something that implements GuestAddressSpace. As we already switched to using GuestMemoryAtomic in a previous commit, we just need to add the annotations. There's also a minor change to access Queue::next_avail using accessors instead of the field. Signed-off-by: Sergio Lopez <slp@redhat.com>
|
@sameo @rbradford Do we want this PR here, or do you prefer to do this directly within rust-vmm? |
|
@slp Here is probably best. cloud-hypervisor/cloud-hypervisor needs to switch too as I don't think we can really handle depending on two different versions of the same crate! |
|
@rbradford OK, I'll wait for this to get reviewed here. BTW, we're a bit in a hurry as we need this, along with |
rbradford
approved these changes
Oct 2, 2020
sameo
approved these changes
Oct 2, 2020
jiangliu
pushed a commit
that referenced
this pull request
Aug 12, 2021
Fixes #5 Signed-off-by: Sergio Lopez <slp@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits allows
vhost-user-backendto switch to rust-vmm's vhost and vm-virtio crates. I've tried to keep the changes at minimal as possible.There's only one change in the API, which is that the
update_memorymethod from theVhostUserBackendcrate now receives anGuestMemoryMmapwrapped within aGuestMemoryAtomic.